From 316dc3093d8cbb169d747bdce1caa9aad3f21ab2 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Mon, 15 May 2017 12:11:42 -0400 Subject: [PATCH] unix: remove FSEventStreamFlushSync() call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This call, in the context of file watching, appears to trigger assertion warnings on some macOS configurations. Refs: https://github.com/nodejs/node/issues/854 Fixes: https://github.com/libuv/libuv/issues/1334 PR-URL: https://github.com/libuv/libuv/pull/1349 Reviewed-By: Fedor Indutny Reviewed-By: Saúl Ibarra Corretgé --- src/unix/fsevents.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/unix/fsevents.c b/src/unix/fsevents.c index d331a131..643e233c 100644 --- a/src/unix/fsevents.c +++ b/src/unix/fsevents.c @@ -378,9 +378,6 @@ static void uv__fsevents_destroy_stream(uv_loop_t* loop) { if (state->fsevent_stream == NULL) return; - /* Flush all accumulated events */ - pFSEventStreamFlushSync(state->fsevent_stream); - /* Stop emitting events */ pFSEventStreamStop(state->fsevent_stream);