Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export of isordered method #45

Closed
eulerkochy opened this issue May 24, 2020 · 2 comments
Closed

export of isordered method #45

eulerkochy opened this issue May 24, 2020 · 2 comments

Comments

@eulerkochy
Copy link
Member

Is the isordered method exported? DataStructures.jl imports it from OrderedCollections. But, this is strange.

julia> using OrderedCollections;

julia> isordered(typeof(OrderedDict()))
ERROR: UndefVarError: isordered not defined
Stacktrace:
 [1] top-level scope at none:0

when I include("src/ordered_dict.jl"), I do get an expected output.

julia> include("src/ordered_dict.jl")
merge (generic function with 2 methods)

julia> isordered(typeof(OrderedDict()))
true

This seems a bug to me. A simple export isordered is missing. But, can anyone else confirm?

@eulerkochy
Copy link
Member Author

Nvm.
Giving it a read solves the problem.
https://docs.julialang.org/en/v1/manual/modules/#Summary-of-module-usage-1

@nalimilan
Copy link

For reference, CategoricalArrays and Arrow.jl use the name isordered too (see JuliaData/DataAPI.jl#26). If OrderedCollections ever wanted to export isordered it would be nice to coordinate. I'm not sure to what extent it would make sense for these to be the same function, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants