-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD5 stopped working for Julia 1.11 #11
Comments
Thanks for reporting. Does SHA.jl work nightly, can you check? |
@jw3126 - my apologies for the delayed reply. As far as I can tell, SHA,jl is functioning normally on the most recent nightly build (1.11.0-DEV.643). All I tried was the example in the repo's readme, namely:
The output is the same as under Julia v1.9.3. I also tested MD5 today under the current nightly build and the error is still the same as reported last week, so it seems that only MD5 is affected. If you would like me to run a different test, please let me know. |
I also just ran the package unit tests for the two packages under the current nightly build. SHA.jl passes all of its unit tests whereas MD5.jl fails its tests with the same error as previously reported. |
Ok since both package were not touched for a long time, maybe report as a julia bug? |
does MD5 pass on v1.9? Maybe there was a breaking change 4 months ago in SHA https://github.com/JuliaCrypto/SHA.jl/blame/e1af7dd0863dee14a83550faf4b6e08971993ce8/src/common.jl#L20 ? |
@jw3126 - Yes, tests pass for Julia 1.9.3 on my machine, as well as as for 1.10.0-beta3. |
Yeah, that change in SHA added the So this is an incompatibility between SHA.jl and MD5.jl |
@jakobnissen any chance you could also apply your SHA.jl change JuliaCrypto/SHA.jl@5e3a676 here? |
this puzzles me, did you use the same SHA.jl versions? |
Somewhere between Julia 1.11.0-DEV.550 (working) and 1.11.0-DEV.555 (failing), based on when my unit test reports making use of MD5 checksums started failing, something seems to have broken.
I'm not sure how to begin debugging this problem, or whether it would be better to file the issue in the SHA.jl repo or the the main julialang repo. The stack trace does not make much sense to me, and none of the referred to lines seem to have been touched in a long time.
Current "nightly" output (Julia 1.11.0-DEV.590)
Expected output (Julia 1.9.3)
The text was updated successfully, but these errors were encountered: