Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use limit=false by default in show? #1631

Open
nalimilan opened this issue Dec 12, 2018 · 9 comments
Open

Use limit=false by default in show? #1631

nalimilan opened this issue Dec 12, 2018 · 9 comments
Labels
Milestone

Comments

@nalimilan
Copy link
Member

The show method for Array defaults to :limit => false when the I/O stream/context doesn't set the property (notably stdout). Maybe we should do the same for consistency. See discussion at #1627.

@bkamins bkamins mentioned this issue Jan 15, 2019
31 tasks
@bkamins bkamins added the breaking The proposed change is breaking. label Feb 12, 2020
@bkamins bkamins added this to the 2.0 milestone Feb 12, 2020
@bkamins bkamins added display and removed breaking The proposed change is breaking. labels Aug 7, 2020
@bkamins
Copy link
Member

bkamins commented Nov 8, 2020

@ronisbr - is this still an issue with PrettyTables.jl?

@ronisbr
Copy link
Member

ronisbr commented Nov 9, 2020

Yes, the behavior is the same as before. If I use show without an io, then the output gets cropped by default.

@bkamins
Copy link
Member

bkamins commented Nov 9, 2020

Then do you think it is worth to keep it open? (or maybe if it makes sense in general - maybe move the issue to PrettyTables.jl?)

@nalimilan
Copy link
Member Author

One advantage of having show(df) not crop output is that people would easily have access to two different output formats: df at the REPL gives the cropped output, and show(df) would give the full output (instead of having to use e.g. show(df, allrows=true). But the output isn't readable when columns don't fit in the screen, so that wouldn't be very useful. Maybe we could use allrows=true but allcols=false by default though.

TBH I'm not sure why arrays behave like they do. The result is generally unreadable even for small ones.

@bkamins
Copy link
Member

bkamins commented Nov 9, 2020

I would just pick what we believe is useful. Being super consistent with Base here is not a top priority I think.

@nalimilan
Copy link
Member Author

But what is useful? :-) Maybe make a poll in #data?

@bkamins
Copy link
Member

bkamins commented Nov 9, 2020

sure why not. Could you do it please? (as I believe you know exactly which case is important to compare)

@ronisbr
Copy link
Member

ronisbr commented Nov 9, 2020

Then do you think it is worth to keep it open? (or maybe if it makes sense in general - maybe move the issue to PrettyTables.jl?)

This cannot be fixed inside PrettyTables.jl. It is related to the default configurations of allrows and allcols depending on how show is called.

@bkamins
Copy link
Member

bkamins commented Nov 9, 2020

OK - so let us keep it open here.

@bkamins bkamins modified the milestones: 1.x, 1.5 Sep 13, 2022
@bkamins bkamins modified the milestones: 1.5, 1.6 Feb 5, 2023
@bkamins bkamins modified the milestones: 1.6, 1.7 Jul 10, 2023
@bkamins bkamins modified the milestones: 1.7, 1.x Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants