Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename allowcomments to ignorecomments #1860

Closed
KwatMDPhD opened this issue Jun 24, 2019 · 2 comments
Closed

Rename allowcomments to ignorecomments #1860

KwatMDPhD opened this issue Jun 24, 2019 · 2 comments

Comments

@KwatMDPhD
Copy link

Screenshot from 2019-06-24 16-29-08

The argument name suggests opposite behavior and can be confusing.

@bkamins
Copy link
Member

bkamins commented Jun 25, 2019

As you noted in #1602 this functionality is deprecated. In particular it is OK if someone wants to maintain it as a separate project. Our objective is to remove it from DataFrames.jl codebase, because it is not a part of what needs to be in DataFrames.jl package (having multiple ancillary functionalities in DataFrames.jl was needed in the past when the package ecosystem was not as mature, but now we tend to have one package provide only one consistent set of functionalities).

Therefore, as it was mentioned in the comment #1602 (comment), please feel free to take the codes of readtable/writetable and make a package of them if you wish.

@bkamins bkamins closed this as completed Jun 25, 2019
@nalimilan
Copy link
Member

Therefore, as it was mentioned in the comment #1602 (comment), please feel free to take the codes of readtable/writetable and make a package of them if you wish.

Better file issues against CSV.jl. We really don't need an additional CSV parsing package in the ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants