Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional functions supported for DataFrame.jl #2088

Closed
bkamins opened this issue Jan 22, 2020 · 2 comments
Closed

Additional functions supported for DataFrame.jl #2088

bkamins opened this issue Jan 22, 2020 · 2 comments
Labels
non-breaking The proposed change is not breaking
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Jan 22, 2020

We could consider adding support for count for AbstractDataFrame like we now support filter (also #2048 is related).

Additionally now filter is very inefficeint, we could introduce additional form:

filter(col => fun, df)

that will be much faster as it would be type stable. This is a style planned for select (the only difference is that fun is applied to each element, not a whole column).

@bkamins
Copy link
Member Author

bkamins commented Jan 26, 2020

#2091 adds filter/filter! proposal. I leave count for later when we decide what to do with #2048 and similar.

@bkamins bkamins added the non-breaking The proposed change is not breaking label Feb 12, 2020
@bkamins bkamins added this to the 2.0 milestone Feb 12, 2020
@bkamins
Copy link
Member Author

bkamins commented Oct 15, 2022

I would close it. I have not seen any requests for count.

@bkamins bkamins closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking The proposed change is not breaking
Projects
None yet
Development

No branches or pull requests

1 participant