Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tables.namedtupleiterator implementation #2100

Closed
bkamins opened this issue Feb 6, 2020 · 2 comments · Fixed by #2117
Closed

Add Tables.namedtupleiterator implementation #2100

bkamins opened this issue Feb 6, 2020 · 2 comments · Fixed by #2117
Assignees
@bkamins
Labels
non-breaking The proposed change is not breaking
Milestone
1.0

Comments

@bkamins
Copy link
Member

bkamins commented Feb 6, 2020

Following JuliaData/Tables.jl#131 (comment) we should add:

Tables.namedtupleiterator(df::AbstractDataFrame) = Tables.namedtupleiterator(Tables.columntable(df))

after that PR is closed and new version of Tables.jl tagged.
@bkamins bkamins self-assigned this Feb 6, 2020
@bkamins bkamins mentioned this issue Feb 7, 2020
Merged
@bkamins
Copy link
Member Author

bkamins commented Feb 8, 2020

@quinnj - having JuliaData/Tables.jl#131 merged should we additionally change anything in DataFrames.jl apart from the change I describe here (which is only performance related)?

@quinnj
Copy link
Member

quinnj commented Feb 8, 2020

Yes, I have the changes in a local branch; let me see if I can push them here

@bkamins bkamins added the non-breaking The proposed change is not breaking label Feb 12, 2020
@bkamins bkamins added this to the 1.0 milestone Feb 12, 2020
@bkamins bkamins mentioned this issue Feb 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkamins bkamins

Labels
non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

improve speed of Tables.namedtupleiterator bkamins/DataFrames.jl
2 participants
@quinnj @bkamins