Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall mapcols be deprecated? #2186

Closed
bkamins opened this issue Apr 14, 2020 · 4 comments
Closed

Shall mapcols be deprecated? #2186

bkamins opened this issue Apr 14, 2020 · 4 comments
Labels
breaking The proposed change is breaking. decision
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Apr 14, 2020

@deprecate `mapcols(fun, df)` select(df, names(df) .=> fun .=> names(df))

the only benefit of mapcols is that it allows for do block, so maybe we should leave it.

CC @nalimilan @oxinabox

@bkamins bkamins added breaking The proposed change is breaking. decision labels Apr 14, 2020
@bkamins bkamins added this to the 1.0 milestone Apr 14, 2020
@nalimilan
Copy link
Member

I guess the main reason to remove it would be to reduce the number of functions ending in "cols" (the other one being insertcols!). Otherwise it doesn't really hurt to have it.

@bkamins
Copy link
Member Author

bkamins commented Apr 15, 2020

Well - we want to deprecate aggregate to reduce the number of functions we expose.

What difference do you see between aggregate and mapcols here?.

@nalimilan
Copy link
Member

aggregate is a very generic term which means different things in other languages. mapcols! is more explicit. But I'm not particularly attached to it. IIRC it mainly exists because it used to be map when DataFrames were column-oriented, but it may not have a very good reason to exist. I imagine the main use case is standardizing columns.

@bkamins
Copy link
Member Author

bkamins commented Apr 15, 2020

OK - let us just keep it. I am closing the issue.

@oxinabox - please reopen (or comment to reopen - I am not sure if you have rights to reopen issues in this repo) if you feel it is worth to deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking The proposed change is breaking. decision
Projects
None yet
Development

No branches or pull requests

2 participants