Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible test failure in upcoming Julia version 1.5 #2221

Closed
rfourquet opened this issue May 3, 2020 · 3 comments · Fixed by #2223
Closed

possible test failure in upcoming Julia version 1.5 #2221

rfourquet opened this issue May 3, 2020 · 3 comments · Fixed by #2223
Labels
CI non-breaking The proposed change is not breaking
Milestone
1.x

Comments

@rfourquet
Copy link
Contributor

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/DataFrames/1.5.0-DEV-87d2a04de3.log
@bkamins
Copy link
Member

bkamins commented May 3, 2020

@rfourquet - thank you for caring so much to inform the package maintainers about the change!

@bkamins bkamins added CI non-breaking The proposed change is not breaking labels May 3, 2020
@bkamins bkamins added this to the 1.x milestone May 3, 2020
@bkamins
Copy link
Member

bkamins commented May 3, 2020

@nalimilan - I will make this update after #2214 is merged. It affects only tests so it can be done after 0.21 release

@bkamins bkamins mentioned this issue May 4, 2020
Merged
@bkamins
Copy link
Member

bkamins commented May 4, 2020

In #2223 I have made the tests independent of PRNG used (which should have been done from the start).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.x
Development

Successfully merging a pull request may close this issue.

updates required for Julia 1.5 bkamins/DataFrames.jl
2 participants
@bkamins @rfourquet