Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code blocks missing syntax highlighting in docs #2319

Closed
anandijain opened this issue Jul 18, 2020 · 2 comments
Closed

Some code blocks missing syntax highlighting in docs #2319

anandijain opened this issue Jul 18, 2020 · 2 comments
Labels

Comments

@anandijain
Copy link
Contributor

In the docs, I noticed that there are multiple examples of jldoctest dataframe or julia missing from the beginning of code blocks.

It is easy enough to make a PR, but I'm wondering if there is a reason that certain ones have it and others don't.

Thanks!

@bkamins bkamins added the doc label Jul 19, 2020
@bkamins
Copy link
Member

bkamins commented Jul 19, 2020

There is no reason currently.

At some point we want to turn on checking if the documentation actually reproduces the current behavior - then we should clean this thing up.

So in short - the PR would be really welcome, but then it would be preferable to make sure that examples actually pass tests when docstring checking is turned on.

@bkamins
Copy link
Member

bkamins commented Dec 4, 2022

This is done now

@bkamins bkamins closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants