Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable reached during combine #2370

Closed
tk3369 opened this issue Aug 14, 2020 · 2 comments
Closed

Unreachable reached during combine #2370

tk3369 opened this issue Aug 14, 2020 · 2 comments

Comments

@tk3369
Copy link
Contributor

tk3369 commented Aug 14, 2020

How to reproduce:

using CSV
using DataFrames
using Pipe
using Dates

url = "http://files.zillowstatic.com/research/public_v2/zhvi/Metro_zhvi_uc_sfrcondo_tier_0.33_0.67_sm_sa_mon.csv"
housing = DataFrame(CSV.File(download(url)))

housing_stacked = @pipe housing |>
    stack(_, Not([:RegionID, :SizeRank, :RegionName, :RegionType, :StateName])) |>
    rename(_, :variable => :date) |>
    transform(_, :date => (v -> Date.(get.(v))) => :date)

housing_by_year = @pipe housing_stacked |>
    transform(_, :date => ByRow(d -> Year(d).value) => :year) |>
    select(_, Not(:date)) |>
    groupby(_, Not(:value)) |>
    combine(_, :value => sum)

Stack trace:

Unreachable reached at 0x7f5ad01b6950

signal (4): Illegal instruction
in expression starting at REPL[8]:1
groupreduce at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:1023
unknown function (ip: 0x7f5ad01b6986)
Reduce at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:1032
unknown function (ip: 0x7f5ad01b6846)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2159 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2323
_combine at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:1150
#combine_helper#391 at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:589
combine_helper##kw at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:585
unknown function (ip: 0x7f5ad01adfd1)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2159 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2323
#_combine_prepare#379 at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:553
unknown function (ip: 0x7f5ad01abfef)
_combine_prepare##kw at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:482 [inlined]
#combine#378 at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:474 [inlined]
combine at /home/admin/.julia/packages/DataFrames/lfoTw/src/groupeddataframe/splitapplycombine.jl:474
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2159 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2323
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1700 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:369
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:458
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:409 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:817
jl_interpret_toplevel_thunk at /buildworker/worker/package_linux64/build/src/interpreter.c:911
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:819
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:769
jl_toplevel_eval_in at /buildworker/worker/package_linux64/build/src/toplevel.c:848
eval at ./boot.jl:331
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2145 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2323
eval_user_input at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:86
macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/REPL/src/REPL.jl:118 [inlined]
#26 at ./task.jl:358
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2145 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2323
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1700 [inlined]
start_task at /buildworker/worker/package_linux64/build/src/task.c:687
unknown function (ip: (nil))
Allocations: 50030371 (Pool: 50020201; Big: 10170); GC: 56
Illegal instruction

I tried both Julia 1.4.2 and 1.5.0 and they both failed.

@quinnj
Copy link
Member

quinnj commented Aug 14, 2020

This looks like the same issue that was solved in #2335; what version of DataFrames are you on? I think the fix has been released now in the latest tag.

@tk3369
Copy link
Contributor Author

tk3369 commented Aug 15, 2020

Yes, that's it. I was using v0.21.5. Just updated to v0.21.6 and it's working fine now. Thanks!

@tk3369 tk3369 closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants