Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse and reverse! functions similar to sort and sort! #2438

Closed
ppalmes opened this issue Sep 18, 2020 · 3 comments
Closed

Add reverse and reverse! functions similar to sort and sort! #2438

ppalmes opened this issue Sep 18, 2020 · 3 comments
Labels
feature non-breaking The proposed change is not breaking
Milestone

Comments

@ppalmes
Copy link
Contributor

ppalmes commented Sep 18, 2020

  • there are cases where you just want to reverse the order of dataframe and currently there is no implementation of the reverse() function
@bkamins bkamins added feature non-breaking The proposed change is not breaking labels Sep 18, 2020
@bkamins bkamins added this to the 1.x milestone Sep 18, 2020
@Chandu-4444
Copy link
Contributor

I'm trying to implement this. I wrote a function named reverse and put that in src/abstractdataframe/reverse.jl. But when I try to use my function, it didn't get recognized. But I placed the same function in sort.jl and it worked only that the docstrings I wrote weren't recognized (And they didn't show up during ?reverse). Is there somekind of procedure to create new functions in a module?

@Chandu-4444
Copy link
Contributor

Chandu-4444 commented Nov 23, 2021

I'm trying to implement this. I wrote a function named reverse and put that in src/abstractdataframe/reverse.jl. But when I try to use my function, it didn't get recognized. But I placed the same function in sort.jl and it worked only that the docstrings I wrote weren't recognized (And they didn't show up during ?reverse). Is there somekind of procedure to create new functions in a module?

I figured out that I need to add the new files that hold usable functions in ModuleName.jl file. This works fine, and now my function is working. But I didn't understand why my docstrings aren't getting shown when I use ?reverse.

Edit: I figured it out! Made a prototype PR #2944

@bkamins
Copy link
Member

bkamins commented Dec 4, 2022

added in 1.4 release

@bkamins bkamins closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature non-breaking The proposed change is not breaking
Projects
None yet
Development

No branches or pull requests

3 participants