Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final ellipsis appears on next row #2544

Closed
nalimilan opened this issue Nov 15, 2020 · 8 comments
Closed

Final ellipsis appears on next row #2544

nalimilan opened this issue Nov 15, 2020 · 8 comments
Milestone

Comments

@nalimilan
Copy link
Member

I've just spotted a small bug which happens only under certain circumstances: the final ellipsis of the row appears on the next row because there are too many characters to fit on screen. A reproducer is

DataFrame(rand(["dddddffffffffffffddddda", "bbbbbdfffffffffffbfffffffffffffbbbb"], 100, 100))

(Yes, I know that constructor is deprecated... :-p)

See screenshot:
image

Cc: @ronisbr @bkamins

@bkamins
Copy link
Member

bkamins commented Nov 15, 2020

We had this problem in legacy printing. We solved it by deducing 1 from horizontal width.

@bkamins bkamins added this to the 1.0 milestone Nov 15, 2020
@bkamins
Copy link
Member

bkamins commented Nov 15, 2020

@ronisbr - as agreed earlier I mark all display related issues with display badge so that you can easily find and manage them. Thank you!

@ronisbr
Copy link
Member

ronisbr commented Nov 15, 2020

Ok! I found a problem with the cropping mechanism together with a maximum size of the column. This is a bug in PrettyTables.jl. I will try to fix now.

@ronisbr
Copy link
Member

ronisbr commented Nov 15, 2020

The bug will be fixed as soon as PrettyTables.jl v0.10.1 is release. I am just waiting for the next iteration of the registration bot. Sorry about that!

Captura de Tela 2020-11-15 às 20 11 59

@ronisbr
Copy link
Member

ronisbr commented Nov 15, 2020

What a mess a -1 can do :D ronisbr/PrettyTables.jl@44ee6b5

@ronisbr
Copy link
Member

ronisbr commented Nov 15, 2020

Done! Can I close the issue?

@bkamins
Copy link
Member

bkamins commented Nov 16, 2020

It is good now.

@bkamins bkamins closed this as completed Nov 16, 2020
@nalimilan
Copy link
Member Author

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants