Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change valuestransform in unstack #3184

Closed
bkamins opened this issue Sep 26, 2022 · 1 comment · Fixed by #3185
Closed

change valuestransform in unstack #3184

bkamins opened this issue Sep 26, 2022 · 1 comment · Fixed by #3185
Labels
decision
Milestone
1.4

Comments

@bkamins
Copy link
Member

bkamins commented Sep 26, 2022 •
edited
Loading

In this thread #2998 (comment) it is proposed to change valuestransform kwarg name in `unstack to something else.

Please vote for other options:

  1. valuesfunction 👍
  2. valuesaggregate 👎
  3. valuescombine 😃
  4. keep valuestransform 👀
@bkamins bkamins added this to the 1.4 milestone Sep 26, 2022
@bkamins bkamins mentioned this issue Sep 26, 2022
Merged
@bkamins
Copy link
Member Author

bkamins commented Sep 26, 2022

OK, we have discussed the issue with @nalimilan and recommend going for valuesfunction (although it is not a top-vote). The reason why not valuesaggregate is that the functionality provided allows any function, not just aggregation.

@bkamins bkamins mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

rename valuestransform to combine in unstack JuliaData/DataFrames.jl
1 participant
@bkamins