Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on DataStructures should be explicit and versioned #3358

Closed
davidanthoff opened this issue Jul 15, 2023 · 1 comment · Fixed by #3359
Closed

Dependency on DataStructures should be explicit and versioned #3358

davidanthoff opened this issue Jul 15, 2023 · 1 comment · Fixed by #3359
Labels
bug ecosystem Issues in DataFrames.jl ecosystem
Milestone

Comments

@davidanthoff
Copy link
Contributor

import SortingAlgorithms.DataStructures.FasterForward,
SortingAlgorithms.DataStructures.FasterReverse
takes a dependency on DataStructures without declaring that in the Project.toml, and in particular without putting in proper version bounds.

I believe FasterForward was only added in v0.18.0 to DataStructures, so that line of code errors when combined with any older version of DataStructures. I think the immediate fix is very simple: add DataStructures to Project.toml, remove this indirection of importing via SortingAlgorithms and put a DataStructures = 0.18 into the compat section.

The more complicated issue is that we now have a version in the general registry that looks to the package manager as working with DataStructures <v0.18, whereas it does. I think ideally that version would either be yanked, or maybe one can somehow modify the compat bounds in the registry for the existing tagged version?

@bkamins bkamins added this to the patch milestone Jul 15, 2023
@bkamins bkamins added bug ecosystem Issues in DataFrames.jl ecosystem labels Jul 15, 2023
@bkamins
Copy link
Member

bkamins commented Jul 15, 2023

Fixed in #3359 (hopefully cleanly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants