Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would adding support for JLD2.jl allow Type preservation? #3364

Closed
alex-s-gardner opened this issue Jul 27, 2023 · 4 comments
Closed

Would adding support for JLD2.jl allow Type preservation? #3364

alex-s-gardner opened this issue Jul 27, 2023 · 4 comments

Comments

@alex-s-gardner
Copy link

I use DataFrames pretty heavily in my workflows, saving and reading to Arrow file. One thing that I find a bit of a pain is that custom types are lost on save. If DataFrames supported reading and writing to JLD2 could the Types be preserved?

@bkamins
Copy link
Member

bkamins commented Jul 27, 2023

You can currently save and load dataframes using JLD2.jl. Can you please comment what feature are you missing?

@alex-s-gardner
Copy link
Author

Apologies, I didn't realize that was already handled. It works fantastic and retains custom type information!

Should JLD2/H5 be added to the list of supported formats?

@bkamins
Copy link
Member

bkamins commented Jul 28, 2023

If you would think it is useful can you please open a PR?

@quinnj
Copy link
Member

quinnj commented Jul 31, 2023

Custom type preservation should be fine in Arrow.jl as well; it does require defining the right ArrowTypes overloads, but should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants