insert!(df,index,item,name) should modify df in place

[floswald]

i was thinking that the ! in insert! modifies the dataframe in place. this doesnt seem to be happenign at the moment:

x = DataFrame(a=[1,2,3],b=rand(3))
insert!(x,3,rand(3),:newcol)
3x3 DataFrame
|-------|---|----------|----------|
| Row # | a | b        | newcol   |
| 1     | 1 | 0.622669 | 0.906544 |
| 2     | 2 | 0.983419 | 0.262162 |
| 3     | 3 | 0.480157 | 0.263939 |

julia> x
3x2 DataFrame
|-------|---|----------|
| Row # | a | b        |
| 1     | 1 | 0.622669 |
| 2     | 2 | 0.983419 |
| 3     | 3 | 0.480157 |

so i have to do x = insert!(x,...) which is somewhat counterintuitive.

[simonster]

Please check out master and try again. I believe I fixed this in #634 but it hasn't made it into a release yet.

[floswald]

brilliant - thanks!