Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyword argument bug #400

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Fix keyword argument bug #400

merged 3 commits into from
Jul 16, 2024

Conversation

pdeffebach
Copy link
Collaborator

Fixes #399

@pdeffebach
Copy link
Collaborator Author

@bkamins This is a bug-fix that is relatively urgent, see #399

I think this fix is good though. Tests pass both locally and on github actions.

bkamins
bkamins reviewed Jul 16, 2024
View reviewed changes
test/keyword_arguments.jl
correct_view = view(df, df.a .== 1, :)

df2 = @subset(df, :a .== 1, :b .== 3; view = true)
@test df2 ≈ correct_view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you additionally check type of df2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this!

@pdeffebach pdeffebach merged commit 148da7b into master Jul 16, 2024
19 checks passed
pdeffebach added a commit that referenced this pull request Jul 16, 2024
@pdeffebach
Fix tests for #400 (#401)
7ea2e2d 
* fix

* progress

* add news and modify project.toml

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kwargs not passed to subset in @subset with multiple conditions
2 participants
@pdeffebach @bkamins