Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WeakRefStringArray? #36

Closed
andreasnoack opened this issue Apr 25, 2018 · 3 comments
Closed

Deprecate WeakRefStringArray? #36

andreasnoack opened this issue Apr 25, 2018 · 3 comments

Comments

@andreasnoack
Copy link
Member

WeakRefStringArray and StringArray serve the same purpose. We need the latter in JuliaDB for performance so should we deprecate the former?
@quinnj
Copy link
Member

quinnj commented Apr 26, 2018

Yes, I need to switch uses of WeakRefStringArray in DataStreams over to StringArray first (or at least before the deprecation is removed)

@quinnj
Copy link
Member

quinnj commented Mar 12, 2019

Packages that still have uses of WeakRefStringArray:

  • ODBC
  • CSV (tests only)
  • DataStreams
  • DataFrames (only for DataStreams integration)

I'll work on switching them over to to StringArray

@nalimilan nalimilan mentioned this issue Apr 4, 2019
Open
@quinnj
Copy link
Member

quinnj commented May 24, 2019

All known uses of WeakRefStringArray have converted to StringArray.

@quinnj quinnj closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasnoack @quinnj