Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to less evil Documenter 0.24 method for deploying preview docs #153

Closed
oxinabox opened this issue Nov 18, 2019 · 2 comments · Fixed by #200
Closed

Switch to less evil Documenter 0.24 method for deploying preview docs #153

oxinabox opened this issue Nov 18, 2019 · 2 comments · Fixed by #200
Labels
documentation Improvements or additions to documentation

Comments

@oxinabox
Copy link
Member

Onced Documenter 0.24 comes out,
it will have have a standard method for deploying docs for PRs.

We can thus stop using the current hacky one.

JuliaDocs/Documenter.jl#1131

@nickrobinson251 nickrobinson251 transferred this issue from JuliaDiff/ChainRules.jl Apr 28, 2020
@nickrobinson251 nickrobinson251 added the documentation Improvements or additions to documentation label Apr 28, 2020
@oxinabox
Copy link
Member Author

oxinabox commented Apr 30, 2020

But the problem is Documentor 0.24 has very different CSS, which breaks the styling of the site.
Which is kinda nice right now.

I think a much never version still (0.25?) supports themes so that could be fix again.
But it would be effort

@nickrobinson251
Copy link
Contributor

it would be effort

I took a look into doing this with v0.24 (based on how DrWatson.jl does it), and it is very painful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants