Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert video HTML tag for images ending with ".webm" #1034

Merged
merged 4 commits into from
Jun 16, 2019

Conversation

richiejp
Copy link
Contributor

@richiejp richiejp commented Jun 5, 2019

Markdown elements like ![Alt video text](dir/video.webm) will be inserted
with a video HTML element in a similar way to Gitlab markdown.

@mortenpi mortenpi added this to the 0.23.0 milestone Jun 5, 2019
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Basically, an oversight that we already don't support this.

src/Writers/HTMLWriter.jl Outdated Show resolved Hide resolved
src/Writers/HTMLWriter.jl Outdated Show resolved Hide resolved
src/Writers/HTMLWriter.jl Outdated Show resolved Hide resolved
src/Writers/HTMLWriter.jl Outdated Show resolved Hide resolved
Markdown image elements like `![Alt video text](dir/video.webm)` will be
rendered with a video HTML element in a similar way to Gitlab markdown.
@richiejp
Copy link
Contributor Author

Thanks for the feedback. I was on holiday, so couldn't respond straight away.

@mortenpi mortenpi added the Format: HTML Related to the default HTML output label Jun 13, 2019
src/Writers/HTMLWriter.jl Outdated Show resolved Hide resolved
@mortenpi
Copy link
Member

@richiejp Thanks for the contribution! Will merge once the tests complete.

@mortenpi mortenpi merged commit 2bc7ffa into JuliaDocs:master Jun 16, 2019
richiejp pushed a commit to richiejp/jdp that referenced this pull request Jul 2, 2019
Hopefully temporary change while waiting for documenter to merge PR.
JuliaDocs/Documenter.jl#1034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants