Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale figures to textwidth in latex writer #1137

Merged
merged 5 commits into from
Oct 6, 2019
Merged

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Sep 25, 2019

This isn't an ideal solution since we're also going to upscale small images, but fixing that is nontrivial.

@mortenpi mortenpi added Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement labels Sep 26, 2019
@mortenpi mortenpi added this to the 0.24.0 milestone Sep 26, 2019
@mortenpi
Copy link
Member

What about adjustbox?

@pfitzseb
Copy link
Member Author

Yeah, that's also one of the solutions mentioned in the stackoverflow post I linked. Is just adding packages here ok?

@mortenpi
Copy link
Member

Yep, I'd put them in the .sty. The only thing that would be good to check is to make sure that it still builds fine with the Docker image, i.e. that we have adjustbox available in the image.

@pfitzseb
Copy link
Member Author

Alright, changed to the adjustbox setup and can confirm the docker build still works fine.

@mortenpi
Copy link
Member

mortenpi commented Oct 5, 2019

LGTM, will merge shortly. Thanks @pfitzseb!

@mortenpi mortenpi merged commit 32ba2fc into master Oct 6, 2019
@mortenpi mortenpi deleted the sp/latexfigwidth branch October 6, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants