Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Selector cache before running build pipeline #1452

Merged
merged 2 commits into from
Oct 25, 2020

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Oct 24, 2020

Small follow-up to #1440, to make sure that we would retain the feature where you can add selector stages between makedocs calls.

Just to make it concrete, with the current master the DummyBuildStage warning does not get printed if you run the following (but does work pre-#1440):

using Documenter: Documenter, makedocs, Selectors
makedocs(sitename = "foo")
abstract type DummyBuildStage <: Documenter.Builder.DocumentPipeline end
Selectors.order(::Type{DummyBuildStage}) = 2.5
Selectors.runner(::Type{DummyBuildStage}, args...) = @warn "DummyBuildStage"
makedocs(sitename = "foo")

@epatters I believe this should not affect the Catlab build times?

Close #1438

@mortenpi mortenpi added this to the 0.25.3 milestone Oct 24, 2020
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had written a comment suggesting this already in the original PR, but deleted it since it was easier to just press the button 😛

@mortenpi
Copy link
Member Author

but deleted it since it was easier to just press the button

Somehow I immediately thought of this https://youtu.be/1OitCT1KT4k?t=158 (from 2:38) 😆

@epatters
Copy link
Contributor

Thanks, can confirm that this does not affect the Catlab build time.

@mortenpi mortenpi merged commit 9801cf4 into master Oct 25, 2020
@mortenpi mortenpi deleted the mp/empty-selector-cache branch October 25, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heavy slowdown in ExpandTemplates due to subtypes function
3 participants