Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let sitename link back to document root just like the logo. #1553

Merged
merged 5 commits into from
Mar 28, 2021
Merged

Let sitename link back to document root just like the logo. #1553

merged 5 commits into from
Mar 28, 2021

Conversation

fredrikekre
Copy link
Member

No description provided.

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Enhancement labels Mar 17, 2021
@mortenpi mortenpi added this to the 0.27.0 milestone Mar 17, 2021
mortenpi
mortenpi reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Needs a small CSS update as well though: the sitename is blue now (in the light theme) because it is a link. I'd say we want to keep it black, and also make sure it doesn't do anything for hover.

@fredrikekre
Copy link
Member Author

I thought there were instructions somewhere about how to compile the theme but can not find it now. Feel free to push those changes to this branch.

@mortenpi
Copy link
Member

It should be to go from the SCSS to CSS (assuming a Pkg.deved Documenter):

julia> using DocumenterTools: Themes
julia> Themes.compile_native_themes()

@mortenpi mortenpi merged commit 77e0f7e into master Mar 28, 2021
@mortenpi mortenpi deleted the fe/sitename-link branch March 28, 2021 22:00
Arkoniak pushed a commit to Arkoniak/Documenter.jl that referenced this pull request Jun 21, 2021
@fredrikekre @mortenpi
Let sitename link back to document root just like the logo. (JuliaDoc…
6ebc065 
…s#1553)

Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi