Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set permissions: content: write in hosting.md #1829

Merged
merged 1 commit into from
May 26, 2022

Conversation

rikhuijzer
Copy link
Contributor

Fix for the too permissive setting in #1819.

Thanks to @SaschaMann for noting that

This is not a good practice. Instead, only the minimal permissions that are needed to make the workflow work should be given to the token.

See julia-actions/julia-docdeploy#21 for details.

@mortenpi
Copy link
Member

LGTM, thanks!

@mortenpi mortenpi merged commit 18ea900 into JuliaDocs:master May 26, 2022
@fredrikekre
Copy link
Member

Does this allow publishing PR statuses?

@SaschaMann
Copy link

No, those need either statuses or checks.

@mortenpi
Copy link
Member

So deploydocs calls out to these APIs:

push!(cmd.exec, "https://api.github.com/repos/$(owner)/$(repo)/statuses/$(sha)")

push!(cmd.exec, "https://api.github.com/repos/$(repo)/pulls/$(prnr)")

Is statuses: write enough for these?

@rikhuijzer
Copy link
Contributor Author

Is statuses: write enough for these?

Probably also pull-requests: write or what does that second API do? Someone here who can quickly try it out on one of their repositories? I'm not using this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants