Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using ssh-agent, recommend using webfactory/ssh-agent actions #2034

Open
mortenpi opened this issue Feb 7, 2023 · 1 comment
Open

Comments

@mortenpi
Copy link
Member

mortenpi commented Feb 7, 2023

Sort of follow-up to #2018, but I came across the webfactory/ssh-agent action. It should be possible to suggest that people add this to their docs workflows

- uses: webfactory/ssh-agent@v0.7.0
  with:
    ssh-private-key: ${{ secrets.DOCUMENTER_KEY }} # can't be base64 encoded though I assume

And then in deploydocs we could then just authenticate with the agent. This way we could avoid materializing DOCUMENTER_KEY on disk, and could actually avoid exposing the secret to Documenter altogether.

Would need some work to make work, and I think we'd also have to indicate to deploydocs that it should try the agent (something like deploydocs(auth=:sshagent))?

@odow
Copy link
Collaborator

odow commented Nov 1, 2023

Related #1889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants