Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-line math output in HTMLWriter #2281

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Fix in-line math output in HTMLWriter #2281

merged 8 commits into from
Sep 28, 2023

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 21, 2023

Before I add tests etc for #2280, is this something that would be considered? Or should all MIME"text/latex" outputs be display math?

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels fine to me. We'll show it as display math.. I think..? Or at least should if we don't, for consistency (at-blocks should output blocks). But no harm in being permissive with the input here I think.

src/html/HTMLWriter.jl Outdated Show resolved Hide resolved
@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Sep 21, 2023
@odow
Copy link
Collaborator Author

odow commented Sep 21, 2023

We'll show it as display math.. I think..?

Yeah, I think so. But that's okay.

test/htmlwriter.jl Outdated Show resolved Hide resolved
src/html/HTMLWriter.jl Outdated Show resolved Hide resolved
@odow
Copy link
Collaborator Author

odow commented Sep 22, 2023

I refactored a bit and used a different regex.

@odow
Copy link
Collaborator Author

odow commented Sep 28, 2023

Thoughts @mortenpi?

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Documenter went on the backburner for a few days. But this looks great. And the refactoring makes the code much cleaner!

Let me just add a quick thing into the example builds.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Did you want to do anything else or is this good to go?

@odow
Copy link
Collaborator Author

odow commented Sep 28, 2023 via email

@mortenpi mortenpi enabled auto-merge (squash) September 28, 2023 07:22
@mortenpi mortenpi merged commit d3bdbc1 into master Sep 28, 2023
20 of 21 checks passed
@mortenpi mortenpi deleted the od/latex-dollar branch September 28, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants