-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in-line math output in HTMLWriter #2281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels fine to me. We'll show it as display math.. I think..? Or at least should if we don't, for consistency (at-blocks should output blocks). But no harm in being permissive with the input here I think.
Yeah, I think so. But that's okay. |
I refactored a bit and used a different regex. |
Thoughts @mortenpi? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Documenter went on the backburner for a few days. But this looks great. And the refactoring makes the code much cleaner!
Let me just add a quick thing into the example builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Did you want to do anything else or is this good to go?
Good by me
…On Thu, 28 Sept 2023, 8:18 pm Morten Piibeleht, ***@***.***> wrote:
***@***.**** approved this pull request.
This LGTM. Did you want to do anything else or is this good to go?
—
Reply to this email directly, view it on GitHub
<#2281 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6MQJOTKZOV7TMVWQMMBYTX4UQF3ANCNFSM6AAAAAA5CH2Y6E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Before I add tests etc for #2280, is this something that would be considered? Or should all
MIME"text/latex"
outputs be display math?