Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom Translation on Assets and Text #977

Closed
Roger-luo opened this issue Mar 5, 2019 · 2 comments
Closed

[Feature Request] Custom Translation on Assets and Text #977

Roger-luo opened this issue Mar 5, 2019 · 2 comments

Comments

@Roger-luo
Copy link
Contributor

Roger-luo commented Mar 5, 2019

There are some text in English generated by rendering, it would nice if we could change these text to customized version. e.g

direction = span[".direction"]("Next")

And also it would nice to allow have custom html lang tag, e.g zh-cn

FYI:
JuliaCN/JuliaZH.jl#49

We are using a overwritten version of the above functions as a workaround in JuliaZH currently.

@mortenpi
Copy link
Member

mortenpi commented Mar 6, 2019

We could definitely support this, I would be happy to review a PR for this. Passing a custom dictionary to HTML() is probably the way to go. Or perhaps there is some better approach to i18n library code?

@odow
Copy link
Collaborator

odow commented Nov 1, 2023

Closing in favor of #297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants