-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize to other writers (LatexWriter) #18
Comments
LatexWriter
)
LatexWriter
)
There's two potential routes to implementing this (or citation rendering in general):
Approach 2 is probably easier, but I'll detail the advantages and disadvantages of both strategies below. Currently we only support the HTML writer, but the strategy is a mix of the two approaches:
So in any case, we'll have to change the internals to generalize to Approach 1 (universal AST)Fundamentally, this does all the rendering within We'll not have to change anything related to This approach is advocated for in the old JuliaDocs/Documenter.jl#1162 (comment). As pointed out there, there will probably have to be a Advantages
Disadvantages
So, "more work to implement" is probably the only real disadvantage. Approach 2 (raw nodes, exploit
|
From @Seelengrab on Slack:
That might still be a good idea and would fit in with either approach! |
Although it would push a lot of the logic from the expander stage into the writer stage, and I'm not sure how well it fits with what I just did in #43, so I'll have to think about that more |
I've looked a bit more into Approach 1, and it turns out to be a lot more straightforward to implement than I first thought. So, none of the drawbacks actually turned out to be real, while all the advantages materialized. In fact, having the So at this point, Approach 1 is absolutely the way to go. I have a working prototype, which I'll clean up and push after #43 is merged. |
Right; any third party writer plugin would have to overload their Another advantage is that the default Documenter pipeline already uses
So from my naive (hah, I should learn to not be naive about difficulties with LaTeX 😂) POV, this should "just work" if the
it could even support multiple bibliographies by specifying their paths in that block. |
Awesome! You're a lifesaver! |
Transferred from JuliaQuantumControl/QuantumCitations.jl#7
It might be better not to generate raw HTML for the bibliography. See the comments at JuliaDocs/Documenter.jl#1162 (comment)
The text was updated successfully, but these errors were encountered: