Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests for v3 API. #169

Open
Datseris opened this issue Mar 4, 2023 · 0 comments
Open

Performance tests for v3 API. #169

Datseris opened this issue Mar 4, 2023 · 0 comments
Labels
good first issue Issue suited for a first time contributor help wanted performance

Comments

@Datseris
Copy link
Member

Datseris commented Mar 4, 2023

I haven't had the time to extensively test performance of each individual function of the new DynamicalSystems.jl v3.0 API. I've checked the over-arching performance, e.g., lyapunovspectrum has approximately same speed as before.

But one should be methodical here. All functions that participate in the DynamicalSystem api should be non allocating. E.g. set_deviations(tands, Q) should be non allocating regardless of what type of tangent dynamical system we have.

Someone should check these functions with the @benchmark from BenchmarkTools.jl.

@Datseris Datseris added help wanted good first issue Issue suited for a first time contributor performance labels Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue suited for a first time contributor help wanted performance
Projects
None yet
Development

No branches or pull requests

1 participant