-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Julia 1.11 #415
Conversation
Encountered this locally; let's see if it happens on CI too:
|
The problem is with the Float16 ABI; |
I think the easiest way forward is to pass scalars (e.g. alpha/beta inputs) as references instead of values, avoiding any ABI confusion as seen here. This is also what cuBLAS does, and will help us when targeting BFloat16s in the future. I've updated the manual headers and generated wrappers, but I'm not familiar with the On the Julia side, we shouldn't have to do anything; that's the beauty of the |
I can do that @maleadt. |
Thanks. Feel free to push directly to this PR. |
@maleadt We can't pass scalars by reference instead of by value for all oneMKL routines. |
Why not? We're talking about the Julia<->Support library interface, these references don't have to be passed to MKL itself. |
Ok, so you want the following thing for all routines, right?
|
Yes. Otherwise, we rely on the platform/type-dependent argument passing ABIs, which are ill-defined and changing for types like Float16 and BFloat16. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 79.59% 79.62% +0.03%
==========================================
Files 45 45
Lines 2524 2523 -1
==========================================
Hits 2009 2009
+ Misses 515 514 -1 ☔ View full report in Codecov by Sentry. |
@maleadt All tests passed 🎉 |
Awesome, thanks! I don't see the updated |
I modified |
No description provided.