Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinates not defined #135

Open
nathanielvirgo opened this issue Sep 13, 2022 · 3 comments
Open

coordinates not defined #135

nathanielvirgo opened this issue Sep 13, 2022 · 3 comments
Labels

Comments

@nathanielvirgo
Copy link

I just upgraded to Julia 1.8 and reinstalled my packages, and now the coordinates function is not defined:

julia> using LibGEOS

julia> point = LibGEOS.Point(1.0, 2.0)
Point(Ptr{Nothing} @0x00006000034e0060)

julia> coordinates(point)
ERROR: UndefVarError: coordinates not defined
Stacktrace:
 [1] top-level scope
   @ REPL[3]:1

This means none of my LibGEOS code is working. What can I do?

@evetion
Copy link
Member

evetion commented Sep 13, 2022

It seems v0.7 was a breaking release, although it was not meant to be, for which I apologise.

You can now do:

julia> using LibGEOS

julia> point = LibGEOS.Point(1.0, 2.0)
Point(Ptr{Nothing} @0x0000600003ad4480)

julia> using GeoInterface

julia> GeoInterface.coordinates(point)
2-element Vector{Float64}:
 1.0
 2.0

Also, I would advise to use a Project.toml to pin package versions for production code.

@yeesian yeesian added the bug label Sep 14, 2022
@visr
Copy link
Member

visr commented Sep 16, 2022

@evetion I guess that means we should add the export back? or should it stay?

@evetion
Copy link
Member

evetion commented Sep 19, 2022

Yeah, I think it's best to add the export back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants