Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makie support #142

Open
jw3126 opened this issue Nov 5, 2022 · 2 comments
Open

Makie support #142

jw3126 opened this issue Nov 5, 2022 · 2 comments

Comments

@jw3126
Copy link
Member

jw3126 commented Nov 5, 2022

With GeoInterfaceMakie it is possible to give Makie support to LibGEOS in one line:

https://github.com/JuliaGeo/GeoInterface.jl/blob/40af14b80d0620f44a8a9d4063b1f36d36c60ab9/GeoInterfaceMakie/test/runtests.jl#L8

The question is where that line should live. My preference would be to have it right here in LibGEOS.jl. That would
add GeoInterfaceMakie as a dependency which itself depends on the following:

GeoInterface = "1"  # LibGEOS dependency anyway
GeometryBasics = "0.4.4" # neither super lightweight, nor super heavyweight
MakieCore = "0.5.1" # super lightweight

Is that acceptable?

The alternative would be to create a one-line LibGEOSMakie.jl package.

What do people think about these options?

@visr
Copy link
Member

visr commented Nov 5, 2022

Great that this is possible with one line. What do you think about simply documenting that users need to run this line if they want to plot the geometries with Makie?

@jw3126
Copy link
Member Author

jw3126 commented Nov 5, 2022

Mhh, the call is a macro, that overloads a bunch of methods needed to do Makie plotting. If people need to include this in their scripts or even packages, the macro might be called multiple times and this will yield warnings, recompilation etc.

@jw3126 jw3126 mentioned this issue Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants