Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJ_jll v900.100 breaks (online?) transformation #71

Closed
evetion opened this issue Sep 5, 2022 · 6 comments
Closed

PROJ_jll v900.100 breaks (online?) transformation #71

evetion opened this issue Sep 5, 2022 · 6 comments

Comments

@evetion
Copy link
Member

evetion commented Sep 5, 2022

In v1.0 with the old PROJ_jll this worked fine:

julia> Proj.enable_network!()
julia> trans = Proj.Transformation("EPSG:4326", "EPSG:4326+3855")  # ellipsoid to egm2008 height
julia> trans(0,0,0)
(0.0, 0.0, -17.0154953)

In the new _jll I get (0,0,0), without any errors. Looking at the projinfo output, it seems it skips all pipelines requiring (online) vertical grid transform data and arrives at the last noop operation.

@evetion
Copy link
Member Author

evetion commented Sep 5, 2022

This one does work:

trans = Proj.Transformation("EPSG:4979", "EPSG:3855")

@evetion
Copy link
Member Author

evetion commented Sep 5, 2022

I think this is at the source of the issue: OSGeo/PROJ#3119

@visr
Copy link
Member

visr commented Sep 5, 2022

Ah yes, that looks like the same reason I needed to update some of the tests in #70.

@visr
Copy link
Member

visr commented Sep 6, 2022

I think this can be closed, right? PROJ behavior changed, not much to do here.

@visr visr closed this as completed Sep 6, 2022
@evetion
Copy link
Member Author

evetion commented Sep 6, 2022

We could place a warning in the README to pin PROJ versions? As the API might not break, but your results might suddenly change? I dislike this behaviour.

@visr
Copy link
Member

visr commented Sep 6, 2022

Yeah it might be a good idea to mention that if transformations need to stay exactly the same, users should fix the PROJ_jll version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants