Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch reading for TBaskets #359

Merged
merged 2 commits into from
Oct 24, 2024
Merged

batch reading for TBaskets #359

merged 2 commits into from
Oct 24, 2024

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Oct 24, 2024

fix #358

thanks @alexander-held for reminding me to benchmark again

julia> f() = LazyTree("3148230F-FC33-5240-8EFC-89FF45563A47.root", "Events", r"^Muon")[:]

# before
julia> df = @time f();
 18.882730 seconds (128.33 M allocations: 8.914 GiB, 32.75% gc time, 2.42% compilation time)

julia> df = @time f();
 18.590407 seconds (127.94 M allocations: 8.895 GiB, 33.37% gc time)

# after
julia> df = @time f();
 10.531039 seconds (1.54 M allocations: 5.355 GiB, 12.92% gc time)

julia> df = @time f();
 10.691377 seconds (1.65 M allocations: 5.125 GiB, 12.52% gc time, 1.78% compilation time)

julia> df = @time f();
 11.042397 seconds (1.54 M allocations: 5.119 GiB, 10.94% gc time)

for comparison, uproot

In [15]: %%time
    ...: with up.open("./3148230F-FC33-5240-8EFC-89FF45563A47.root") as f:
    ...:     df = f["Events"].arrays(filter_name="Muon*")
CPU times: user 10.5 s, sys: 122 ms, total: 10.6 s
Wall time: 10.5 s

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.71%. Comparing base (1b190d2) to head (cc3a2f7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/iteration.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   84.72%   84.71%   -0.02%     
==========================================
  Files          21       21              
  Lines        3084     3094      +10     
==========================================
+ Hits         2613     2621       +8     
- Misses        471      473       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf merged commit ace1acb into main Oct 24, 2024
9 of 11 checks passed
@Moelf Moelf deleted the batched_reading_ttree branch October 24, 2024 10:30
@tamasgal
Copy link
Member

Awesome, release! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad bulk reading performance for TTree
2 participants