Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Improved string safety, and slight performance considerations #104

Closed
wants to merge 2 commits into from

Conversation

jakewilliami
Copy link

  • Improved string safety by using SubString, prevind, nextind, firstindex, and lastindex where possible.
  • Made performance improvements by changing findfirst(isequal(c), str) to findfirst(c, str) (no allocating, much faster), and by searching for isdigit instead of using regex within addcommas. Using SubString also seemed to be faster.

All tests passing. Please let me know if you need anything else 🙂

@kescobo
Copy link
Member

kescobo commented Mar 1, 2024

This package is no longer maintained (see #111). Please consider using Format.jl instead, and if this feature is unavailable / still desired, open an issue or PR there.

@kescobo kescobo added the wontfix label Mar 1, 2024
@kescobo kescobo closed this Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants