Support for WebP #67
Support for WebP #67
Conversation
stemann
force-pushed
the
feature/webp
branch
6 times, most recently
from
72e0f23
to
effa597
Compare
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 94.93% 95.50% +0.56%
==========================================
Files 1 1
Lines 79 89 +10
==========================================
+ Hits 75 85 +10
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
@stemann is this PR ready to go from your perspective? |
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
|
Yes, ready to go |
|
Will merge tomorrow (Aug 8) if no objections are forthcoming! |
|
Bump :-) |
| @@ -28,6 +29,7 @@ PNGFiles = "0.3, 0.4" | |||
| QOI = "1" | |||
| Sixel = "0.1.2" | |||
| TiffImages = "0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10" | |||
| WebP = "0.1.2" | |||
There was a problem hiding this comment.
| WebP = "0.1.2" | |
| WebP = "0.1" |
There was a problem hiding this comment.
The restriction to >= 0.1.2 was on purpose - there were some bad bugs in 0.1.0 and 0.1.1.
There was a problem hiding this comment.
Shouldn't it be >=0.1.2 then ? I always forget if the >= is implied or if it pins the version.
There was a problem hiding this comment.
0.1.2 means >=0.1.2, <0.2.0 which is semantically differnt from >=0.1.2.
There was a problem hiding this comment.
Always forget this one, thanks for the correction 😌.
There was a problem hiding this comment.
@stemann it would be great if you'd like to move the WebP package into JuliaIO for broader visibility and consistent maintainence.
Adds support for WebP.
- provided JuliaRegistries/General#104921 is merged.