Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4? #70

Closed
IanButterworth opened this issue Aug 10, 2020 · 8 comments
Closed

Release 0.4? #70

IanButterworth opened this issue Aug 10, 2020 · 8 comments

Comments

@IanButterworth
Copy link
Member

IanButterworth commented Aug 10, 2020

0.4 has sat on master since we stalled the release JuliaRegistries/General#5939

There have been a number of beneficial changes since, so it would be good to put out a release.

Also, with #61 upcoming, it would be good to get a stable release before that merges

cc. @andrewadare @mgkuhn @samuelpowell

@samuelpowell
Copy link
Collaborator

@ianshmean can you remind me why we stopped that registration?

@andrewadare any objections to releasing 0.4, I'm happy to do it.

@andrewadare
Copy link
Contributor

I do not have any objections to releasing version 0.4. I also think we should get #61 merged and make a release from that. That PR has sat without approval for a long time, but it is ready to be merged.

@IanButterworth
Copy link
Member Author

The issue was this: #45 (comment)

So we're ok with releasing 0.4 on the current master? And let's get #61 pushed out quickly after

@mgkuhn
Copy link
Collaborator

mgkuhn commented Aug 14, 2020

#61 still needs to fix the default flow-control settings, such that the binary-transparency tests also pass on e.g. Ubuntu Linux (where XON/XOFF is active by default). But feel free to merge #61 into master and I'll then quickly follow up with PRs for that, and perhaps also for restoring the timeout functionality.

@samuelpowell
Copy link
Collaborator

Okay, I'll do a release of 0.4, merge #61 and open an issue linking the comment above pending PR and then potentially 0.5

@IanButterworth
Copy link
Member Author

Just beat you to it @samuelpowell. I registered current master as 0.4 801de82#commitcomment-41470735

@samuelpowell
Copy link
Collaborator

Cross post - I also asked for registration, both requests link to the same PR on registry so it appears the outcome is okay. I will open issue about #61 now.

@samuelpowell
Copy link
Collaborator

0.4 released, hopefully tagbot will tag shortly, will merge #61 to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants