Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An error and a deprecation warning while loading "PBMBinary" format #22

Closed
magister-ludi opened this issue Oct 23, 2020 · 1 comment · Fixed by #23
Closed

An error and a deprecation warning while loading "PBMBinary" format #22

magister-ludi opened this issue Oct 23, 2020 · 1 comment · Fixed by #23

Comments

@magister-ludi
Copy link
Contributor

In the function
load(s::Stream{format"PBMBinary"})
the constructor BitArray(w, h) is called. This should now be BitArray(undef, w, h). In the function
load(s::Stream{format"PBMBinary"})
the call to permuteddimsview has been deprecated. This should now be PermutedDimsArray (since ImageCore version 0.8.17).

I discovered this while adding methods for reading and writing "plain" Netpbm formats. I have code that fixes this issue (including added tests for "PBMBinary" format), and code that adds I/O for plain formats. I can submit this as a single PR, or two separate PRs, whichever seems best.
@timholy
Copy link
Member

timholy commented Oct 23, 2020

I'd gladly take either option, whichever you prefer. Thanks in advance!

@magister-ludi magister-ludi mentioned this issue Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add read/write of text formats magister-ludi/Netpbm.jl
2 participants
@timholy @magister-ludi