Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagBot did not run for 1.0 #25

Closed
timholy opened this issue Nov 3, 2020 · 2 comments
Closed

TagBot did not run for 1.0 #25

timholy opened this issue Nov 3, 2020 · 2 comments

Comments

@timholy
Copy link
Member

timholy commented Nov 3, 2020

The "releases" tab does not list 1.0 despite it having been merged 8 days ago: JuliaRegistries/General#23666
@johnnychen94
Copy link
Member

johnnychen94 commented Nov 6, 2020 •
edited
Loading

Probably it's because Project.toml uses 1.0 instead of 1.0.0. I just modified it back to the standard syntax in a1f8b38
but the v1.0.0 tag seems to be made quite long ago that TagBot doesn't discover.

I manually made a release for this.

cc: @magister-ludi

@magister-ludi
Copy link
Contributor

My apologies, this was the first time I had done this. Once the correct version appeared on JuliaHub I just assumed it had worked. Thanks for fixing it.

@magister-ludi magister-ludi reopened this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timholy @magister-ludi @johnnychen94