Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Upgrading Implot Wrapper to a more recent version #33

Open
AUK1939 opened this issue Sep 4, 2024 · 3 comments
Open

Feature request: Upgrading Implot Wrapper to a more recent version #33

AUK1939 opened this issue Sep 4, 2024 · 3 comments

Comments

@AUK1939
Copy link

AUK1939 commented Sep 4, 2024 •
edited
Loading

Great work! This is very useful.

I was wondering if there are any plans to move to implot v0.16 or at least v0.9+?

Thanks
@JamesWrigley
Copy link
Member

JamesWrigley commented Sep 4, 2024 •
edited
Loading

The package version number is only for the Julia package, looking at the CImGuiPack_jll version it looks like this is currently built for implot v0.14.

@AUK1939
Copy link
Author

AUK1939 commented Sep 4, 2024 •
edited
Loading

Thanks, does this mean the comment in implot_demo.jl is no longer valid?

#= PlotCandlestick requires imgui_internal.h, which is available in cimplot v0.9+ only
# Example for Custom Plotters and Tooltips section.#

@JamesWrigley
Copy link
Member

Yes that should work now, though TBH from a quick glance I don't see anything from imgui_internal in there anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AUK1939 @JamesWrigley