Add ignore_throw support
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/ignore-throw
branch
3 times, most recently
from
0f5d166 to
1f8df2a
Compare
|
CI failures are due to #3 |
|
Caveats above have been resolved, so |
topolarity
force-pushed
the
ct/ignore-throw
branch
2 times, most recently
from
ea32105 to
49e5069
Compare
topolarity
changed the title
ignore_throw supportignore_throw support
gbaraldi
reviewed
Oct 4, 2023
This allows us to filter allocations that occur only when throwing
errors in called functions.
Before this change:
```julia
julia> check_allocs(*, (Matrix{Float64},Matrix{Float64}))
20-element Vector{AllocCheck.AllocInstance}:
...
```
After:
```julia
julia> check_allocs(*, (Matrix{Float64},Matrix{Float64}); ignore_throw=true)
1-element Vector{AllocCheck.AllocInstance}:
Allocation of Matrix{Float64} in ./boot.jl:477
| Array{T,2}(::UndefInitializer, m::Int, n::Int) where {T} =
Stacktrace:
[1] Array
@ ./boot.jl:477 [inlined]
[2] Array
@ ./boot.jl:485 [inlined]
[3] similar
@ ./array.jl:418 [inlined]
[4] *(A::Matrix{Float64}, B::Matrix{Float64})
@ LinearAlgebra ~/.julia/juliaup/julia-1.10.0-beta2+0.x64.linux.gnu/share/julia/stdlib/v1.10/LinearAlgebra/src/matmul.jl:113
```
This allows us to ignore calls to functions that occur only within throw/catch blocks.
topolarity
force-pushed
the
ct/ignore-throw
branch
from
49e5069 to
57cba84
Compare
Since we assume forward-progress, being post-dominated by an `unreachable` means that path must encounter a throw(). This assumption is being re-considered for upcoming versions of Julia, but for the moment it still stands.
topolarity
force-pushed
the
ct/ignore-throw
branch
from
57cba84 to
1856e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to filter allocations that occur only when throwing errors in called functions.
Before this change:
After:
The two outstanding limitations are:
This does not yet filterDonecatchblocks, but it shouldThis does not yet filter functions that are called only fromDonethrow/catchblocks, but it should