Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing fixup, equality support, and serialization support #452

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

LilithHafner
Copy link
Member

I need these helper functions to facilitate checking if a string parses the same way on different versions of JuliaSyntax. They're generally useful/bugfixes/implement missing functionality that should be expected, so I figure I'll include them in src.

Fixes #449 - a hash-== mismatch bug
Implements #450 - supports equality on SyntaxNode
Implements #451 - supports serialization by implementing read and write on Kind. I used strings instead of UInt16 to represent Kind, see inline comment for more info.

@LilithHafner LilithHafner added the enhancement New feature or request label Jul 6, 2024
This was linked to issues Jul 6, 2024
@LilithHafner LilithHafner changed the title Hashing fixup, equality support, and serialization support (with tests) Hashing fixup, equality support, and serialization support Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (3dca95e) to head (3820851).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   95.83%   95.84%           
=======================================
  Files          13       13           
  Lines        3937     3946    +9     
=======================================
+ Hits         3773     3782    +9     
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner LilithHafner merged commit 8a123a1 into main Jul 6, 2024
42 checks passed
@LilithHafner LilithHafner deleted the lh/eq-hash-serialization branch July 6, 2024 16:31
@c42f c42f mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serialization support SyntaxNodes are never equal GreenNode equality and hashing mismatch
1 participant