Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic sourcefile() function #469

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Generic sourcefile() function #469

merged 1 commit into from
Jul 21, 2024

Conversation

c42f
Copy link
Member

@c42f c42f commented Jul 21, 2024

  • Having a generic version of this is useful for other syntax tree types such as JuliaLowering.SyntaxTree
  • Function to get the SourceFile for a syntax object
  • Generic highlight() implementation in terms of this

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.65%. Comparing base (af768dd) to head (222d30c).
Report is 2 commits behind head on main.

Files Patch % Lines
src/syntax_tree.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   95.93%   96.65%   +0.72%     
==========================================
  Files          13       14       +1     
  Lines        3981     4251     +270     
==========================================
+ Hits         3819     4109     +290     
+ Misses        162      142      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Having a generic version of this is useful for other syntax tree types
  such as `JuliaLowering.SyntaxTree`
* Function to get the `SourceFile` for a syntax object
* Generic `highlight()` implementation in terms of this
* Cleanup: Remove internal `interpolate_literal()` function which
  accidentally has still survived from early prototyping.
@c42f c42f force-pushed the caf/sourcefile-highlight branch from 222d30c to 58206a7 Compare July 21, 2024 04:25
@c42f c42f merged commit a41f5e1 into main Jul 21, 2024
36 checks passed
@c42f c42f deleted the caf/sourcefile-highlight branch July 21, 2024 05:09
@c42f c42f mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant