remove unsafe pointer calls #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost entirely unneeded, and entirely unsafe, except for the failure to specify the ccall API correctly.
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 73.86% 73.57% -0.30%
==========================================
Files 12 12
Lines 750 753 +3
==========================================
Hits 554 554
- Misses 196 199 +3
|
|
bump |
yuyichao
reviewed
Nov 6, 2023
Merged
|
Regression: #274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost entirely unneeded, and entirely unsafe, except for the failure to specify the ccall API correctly.