Weird constructor for type alised Dict

[KristofferC]

Happened to see this:

Pkg.jl/src/REPLMode/REPLMode.jl

Lines 296 to 309 in ca9f442

	const APIOptions = Dict{Symbol, Any}
	function APIOptions(options::Vector{Option},
	specs::Dict{String, OptionSpec},
	)::APIOptions
	api_options = Dict{Symbol, Any}()
	enforce_option(options, specs)
	for option in options
	spec = specs[option.val]
	api_options[spec.api.first] = spec.takes_arg ?
	spec.api.second(option.argument) :
	spec.api.second
	end
	return api_options
	end

This is not great, it adds a constructor to a certain type of dictionary. This should likely just be its own type.

[KristofferC]

Same with

Pkg.jl/src/REPLMode/argument_parsers.jl

Line 38 in ca9f442

const PackageToken = Union{PackageIdentifier, VersionToken, Rev, Subdir}

Pkg.jl/src/REPLMode/argument_parsers.jl

Lines 81 to 85 in ca9f442

	PackageToken(word::String)::PackageToken =
	first(word) == '@' ? VersionToken(word[2:end]) :
	first(word) == '#' ? Rev(word[2:end]) :
	first(word) == ':' ? Subdir(word[2:end]) :
	String(word)