From 066457a0b40b27eee94cb36017436762b94be85f Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 31 Oct 2018 15:01:34 +0100 Subject: [PATCH 1/2] Transfer can_inline to subprocess --- src/Operations.jl | 1 + src/Pkg.jl | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/Operations.jl b/src/Operations.jl index 2208e3a0f5..b88e9b9b96 100644 --- a/src/Operations.jl +++ b/src/Operations.jl @@ -1333,6 +1333,7 @@ function test(ctx::Context, pkgs::Vector{PackageSpec}; coverage=false) --color=$(Base.have_color ? "yes" : "no") --compiled-modules=$(Bool(Base.JLOptions().use_compiled_modules) ? "yes" : "no") --check-bounds=yes + --inline=$(Bool(Base.JLOptions().can_inline) ? "yes" : "no") --startup-file=$(Base.JLOptions().startupfile == 1 ? "yes" : "no") --track-allocation=$(("none", "user", "all")[Base.JLOptions().malloc_log + 1]) --eval $code diff --git a/src/Pkg.jl b/src/Pkg.jl index 00154c3133..c002e4b1b0 100644 --- a/src/Pkg.jl +++ b/src/Pkg.jl @@ -148,6 +148,9 @@ passing `coverage=true`. The default behavior is not to run coverage. The tests are executed in a new process with `check-bounds=yes` and by default `startup-file=no`. If using the startup file (`~/.julia/config/startup.jl`) is desired, start julia with `--startup-file=yes`. +Note that the option `--inline=no` is passed to the new process if that +option was also given to the currently running Julia, i.e., if +`Base.JLOptions().can_inline` is false. """ const test = API.test From 73155d3bb5bd8d67f45511b8153c566f428fc018 Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Tue, 6 Nov 2018 14:47:47 -0500 Subject: [PATCH 2/2] Update Pkg.jl --- src/Pkg.jl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Pkg.jl b/src/Pkg.jl index c002e4b1b0..9dd3f50d31 100644 --- a/src/Pkg.jl +++ b/src/Pkg.jl @@ -148,9 +148,8 @@ passing `coverage=true`. The default behavior is not to run coverage. The tests are executed in a new process with `check-bounds=yes` and by default `startup-file=no`. If using the startup file (`~/.julia/config/startup.jl`) is desired, start julia with `--startup-file=yes`. -Note that the option `--inline=no` is passed to the new process if that -option was also given to the currently running Julia, i.e., if -`Base.JLOptions().can_inline` is false. +Inlining of functions during testing can be disabled (for better coverage accuracy) +by starting julia with `--inline=no`. """ const test = API.test