Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a contributing guide in the README #63

Closed
jakobnissen opened this issue May 25, 2024 · 1 comment
Closed

Add a contributing guide in the README #63

jakobnissen opened this issue May 25, 2024 · 1 comment

Comments

@jakobnissen
Copy link
Contributor

jakobnissen commented May 25, 2024

So, this is the result of some yak shaving:

  1. My PR Implement StringPairs for efficient pairs(::AbstractString) julia#51631 fails the StyledString tests. This is going to be fixed on the Julia side in #51631, but this ought to also be fixed on the StyledStrings side. See Use a function over a closure to handle poor inference #62 for details.
  2. However, the master branch of StyledStrings doesn't work with Julia master. Hence, I can't run the tests to see if Use a function over a closure to handle poor inference #62 actually works. This makes it difficult to contribute to this package, because it's unclear what needs to be done to get the package in a functional state to begin with.
@jakobnissen
Copy link
Contributor Author

My bad, I was working on a stale clone of this repo. The real main branch does pass on Julia's master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant