From b461c61a76232bf8a3a715a5138a5a0bac0262ce Mon Sep 17 00:00:00 2001 From: Nicholas Bauer Date: Wed, 16 Jun 2021 10:59:40 -0400 Subject: [PATCH] Remove `@inline` --- base/abstractarray.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/base/abstractarray.jl b/base/abstractarray.jl index 9e3567997388bb..b1348e33f45e30 100644 --- a/base/abstractarray.jl +++ b/base/abstractarray.jl @@ -2342,7 +2342,7 @@ function _typed_hvncat(::Type{T}, shape::Tuple{Vararg{Tuple, N}}, row_first::Boo return A end -@inline function hvncat_fill!(A::Array, row_first::Bool, xs::Tuple) +function hvncat_fill!(A::Array, row_first::Bool, xs::Tuple) # putting these in separate functions leads to unnecessary allocations lenxs = length(xs) lena = length(A) @@ -2370,7 +2370,7 @@ end end end -@inline function hvncat_fill!(A::AbstractArray{T, N}, scratch1::Vector{Int}, scratch2::Vector{Int}, +function hvncat_fill!(A::AbstractArray{T, N}, scratch1::Vector{Int}, scratch2::Vector{Int}, d1::Int, d2::Int, as::Tuple) where {T, N} length(scratch1) == length(scratch2) == N || throw(ArgumentError("scratch vectors must have as many elements as the destination array has dimensions"))