From fbec395fd049948618442569aa3a7708ceed2013 Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 14 Apr 2022 04:19:56 -0400 Subject: [PATCH] [REPL] Fix a REPL test failure by removing an erroneous space in test (#44972) * [REPL] remove erroneous space in test Introduced by https://github.com/JuliaLang/julia/pull/33805 (74f2de13727373b44da76a65ceb5297889d3e482). * Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)" This reverts commit 322fd706a1739daf4776fd050df756e6670ba958. --- stdlib/REPL/test/repl.jl | 2 +- test/runtests.jl | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/stdlib/REPL/test/repl.jl b/stdlib/REPL/test/repl.jl index 05f583c807165..f34b00a8f0595 100644 --- a/stdlib/REPL/test/repl.jl +++ b/stdlib/REPL/test/repl.jl @@ -264,7 +264,7 @@ fake_repl(options = REPL.Options(confirm_exit=false,hascolor=true)) do stdin_wri write(stdin_write, ";") readuntil(stdout_read, "shell> ") Base.print_shell_escaped(stdin_write, Base.julia_cmd().exec..., special=Base.shell_special) - write(stdin_write, """ -e "println(\\"HI\\")\" """) + write(stdin_write, """ -e "println(\\"HI\\")\"""") readuntil(stdout_read, ")\"") proc_stdout_read, proc_stdout = redirect_stdout() get_stdout = @async read(proc_stdout_read, String) diff --git a/test/runtests.jl b/test/runtests.jl index 6a793c57ce33f..4c9ac1cfd869c 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -78,11 +78,6 @@ move_to_node1("Distributed") # Ensure things like consuming all kernel pipe memory doesn't interfere with other tests move_to_node1("stress") -# TODO: remove `REPL` from the "move to node 1" tests. -# We first need to fix the underlying bugs that are causing the `REPL` tests to frequently -# fail on the `test x86_64-apple-darwin` tester on Buildkite. -move_to_node1("REPL") - # In a constrained memory environment, run the "distributed" test after all other tests # since it starts a lot of workers and can easily exceed the maximum memory limited_worker_rss && move_to_node1("Distributed")